Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: fixed linking to SDL library in map_server #95

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

meyerj
Copy link

@meyerj meyerj commented Jan 22, 2019

Fixes linking to libSDLmain.a and libSDL.a in downstream packages.

find_package(SDL REQUIRED)

(with FindSDL.cmake provided by cmake) only sets SDL_LIBRARY and SDL_INCLUDE_DIR (without the trailing S). But catkin_package(DEPENDS <prefix>) looks for <prefix>_INCLUDE_DIRS and <prefix>_LIBRARIES. catkin emits a warning if neither of both is set for a dependency listed in DEPENDS, which should actually be treated as an error. Or catkin could accept multiple commonly used suffixes for include directories and libraries because apparently there is no standard. See related issue ros/catkin#552.

In any case listing SDL in catkin_package(DEPS ...) is equivalent to listing include directories and libraries in INCLUDE_DIRS and LIBRARIES argument lists.

Another candidate to submit a patch upstream (#81).

@meyerj meyerj added the bug label Jan 22, 2019
Copy link

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested patch, LGTM!

@meyerj meyerj merged commit 469bee0 into kinetic Jan 22, 2019
@meyerj meyerj deleted the fix-map_server-linking branch January 22, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants