Use ShelleyNTC for version check in node queries

[carbolymer]

Changelog

- description: |
    Use ShelleyNTC for version check in node queries
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #391

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

• TODO: include shelley NTC version info and/or use separate error for it

[Jimbo4350]

I haven't look at this yet but I'm prematurely requesting changes as this needs to be carefully considered.

[amesgen]

The new logic here looks correct to me.

We also talked about this in the Consensus Office Hours today, and came to the conclusion that we can avoid cardano-api having to implement this more complicated logic by a simple change in Consensus, see IntersectMBO/ouroboros-consensus#862 and IntersectMBO/ouroboros-consensus#863.

[carbolymer]

Thanks @amesgen ! I think I prefer to rely on the consensus change and your assumption:

In order to reduce the number of possible version combinations, we currently follow the convention that all ShelleyNodeToClientVersions in one CardanoNodeToClientVersionX are equal.

this way we can just use NodeToClientVersion and avoid introducing redundant code.
@Jimbo4350 thoughts?

[carbolymer]

Closing because of: #403 (comment)