Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input #613

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

koslambrou
Copy link
Contributor

Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input

Changelog

- description: |
    Fix datum conversion in 'fromShelleyTxOut' when using 'ShelleyBasedEraAlonzo' as input
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@koslambrou
Copy link
Contributor Author

The build is failing because the GHC-8.10 build tells me to remove import Control.Monad (forM_), but that import is required for GHC >= 9. Should I solve this with something like __GLASGOW_HASKELL__ >= 9?

@carbolymer
Copy link
Contributor

@koslambrou

Should I solve this with something like GLASGOW_HASKELL >= 9?

No, we're aiming to avoid CPP as much as possible. Can you try to just import Control.Monad without listing imported functions? If it does not help, can you make that import qualified instead?

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm leaving an approval to @Jimbo4350

cardano-api/internal/Cardano/Api/Tx/Body.hs Outdated Show resolved Hide resolved
@carbolymer
Copy link
Contributor

Can you rebase the PR onto latest main?

@koslambrou koslambrou force-pushed the koslambrou/fix-fromShelleyTxOut branch from 161e433 to 37d66d1 Compare August 19, 2024 15:42
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carbolymer carbolymer added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit fe2ae13 Aug 20, 2024
25 checks passed
@carbolymer carbolymer deleted the koslambrou/fix-fromShelleyTxOut branch August 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants