Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chap & hackage. Remove GHC 9.8 from GHA. #618

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 15, 2024

Changelog

- description: |
    Bump chap & hackage
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Bump chap & hackage. Remove GHC 9.8 from GHA.

cardano-node is not buildable with GHC 9.8 due to direct dependency on ghc in locli package, which pins stm version to a buggy 2.5.1. Thus it's not needed to test this version in CI.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/bump-hackage-chap branch from a76cb13 to e7ad8b8 Compare August 15, 2024 12:30
@carbolymer carbolymer changed the title Bump chap & hackage Bump chap & hackage. Remove GHC 9.8 from GHA. Aug 15, 2024
@carbolymer carbolymer marked this pull request as ready for review August 15, 2024 13:08
@carbolymer carbolymer force-pushed the mgalazyn/chore/bump-hackage-chap branch 2 times, most recently from 5b16063 to dae413b Compare August 15, 2024 13:11
@carbolymer carbolymer force-pushed the mgalazyn/chore/bump-hackage-chap branch from dae413b to 48df681 Compare August 15, 2024 13:25
@carbolymer carbolymer added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit b20f3be Aug 19, 2024
25 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/bump-hackage-chap branch August 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants