Fix era mismatch error in stake-address-info

IntersectMBO · Nov 29, 2023 · 5d247f9 · 5d247f9
1 parent d00a7d4
commit 5d247f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/cardano-cli/src/Cardano/CLI/EraBased/Run/Query.hs b/cardano-cli/src/Cardano/CLI/EraBased/Run/Query.hs
@@ -32,7 +32,6 @@ module Cardano.CLI.EraBased.Run.Query
 
   , DelegationsAndRewards(..)
   , renderQueryCmdError
-  , renderLocalStateQueryError
   , renderOpCertIntervalInformation
   , percentage
   ) where
@@ -821,11 +820,10 @@ runQueryStakeAddressInfoCmd
           & onLeft (left . QueryCmdUnsupportedNtcVersion)
           & onLeft (left . QueryCmdLocalStateQueryError . EraMismatchError)
 
-        ceo <- requireEon ConwayEra era
-
-        stakeVoteDelegatees <- lift (queryStakeVoteDelegatees ceo stakeAddr)
-          & onLeft (left . QueryCmdUnsupportedNtcVersion)
-          & onLeft (left . QueryCmdLocalStateQueryError . EraMismatchError)
+        stakeVoteDelegatees <- monoidForEraInEonA era $ \ceo ->
+          lift (queryStakeVoteDelegatees ceo stakeAddr)
+            & onLeft (left . QueryCmdUnsupportedNtcVersion)
+            & onLeft (left . QueryCmdLocalStateQueryError . EraMismatchError)
 
         return $ do
           writeStakeAddressInfo

diff --git a/cardano-cli/src/Cardano/CLI/Types/Errors/QueryCmdError.hs b/cardano-cli/src/Cardano/CLI/Types/Errors/QueryCmdError.hs
@@ -59,7 +59,7 @@ data QueryCmdError
 renderQueryCmdError :: QueryCmdError -> Doc ann
 renderQueryCmdError = \case
   QueryCmdLocalStateQueryError lsqErr ->
-    renderLocalStateQueryError lsqErr
+    prettyError lsqErr
   QueryCmdWriteFileError fileErr ->
     prettyError fileErr
   QueryCmdHelpersError helpersErr ->

diff --git a/cardano-cli/src/Cardano/CLI/Types/Errors/QueryCmdLocalStateQueryError.hs b/cardano-cli/src/Cardano/CLI/Types/Errors/QueryCmdLocalStateQueryError.hs
@@ -4,27 +4,28 @@
 module Cardano.CLI.Types.Errors.QueryCmdLocalStateQueryError
   ( QueryCmdLocalStateQueryError(..)
   , mkEraMismatchError
-  , renderLocalStateQueryError
   ) where
 
+import           Cardano.Api (Error (..))
 import           Cardano.Api.Pretty
 
 import           Cardano.CLI.Types.Errors.NodeEraMismatchError
 import           Ouroboros.Consensus.Cardano.Block (EraMismatch (..))
 
+import           Prettyprinter ((<+>))
+
 -- | An error that can occur while querying a node's local state.
 newtype QueryCmdLocalStateQueryError
   = EraMismatchError EraMismatch
-  -- ^ A query from a certain era was applied to a ledger from a different
-  -- era.
+  -- ^ A query from a certain era was applied to a ledger from a different era.
   deriving (Eq, Show)
 
 mkEraMismatchError :: NodeEraMismatchError -> QueryCmdLocalStateQueryError
 mkEraMismatchError NodeEraMismatchError{nodeEra, era} =
   EraMismatchError EraMismatch{ ledgerEraName = docToText $ pretty nodeEra
                               , otherEraName = docToText $ pretty era}
 
-renderLocalStateQueryError :: QueryCmdLocalStateQueryError -> Doc ann
-renderLocalStateQueryError = \case
-  EraMismatchError err ->
-    "A query from a certain era was applied to a ledger from a different era: " <> pshow err
+instance Error QueryCmdLocalStateQueryError where
+  prettyError = \case
+    EraMismatchError EraMismatch{ledgerEraName, otherEraName} ->
+      "A query from" <+> pretty otherEraName <+> "era was applied to a ledger from a different era:" <+> pretty ledgerEraName