Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stake-address registration-certificate has the flag --key-reg-deposit-amt, it should not. #504

Closed
CarlosLopezDeLara opened this issue Dec 6, 2023 · 1 comment · Fixed by #509

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Dec 6, 2023

legacy command

cardano-cli stake-address registration-certificate
and era based

cardano-cli babbage stake-address registration-certificate

have the flag --key-reg-deposit-amt but it is really not needed on Babbage. This is purely cosmetic since the resulting certificate does conform to the Babbage cddl. In other words, using this flag does not have any impact but might be confusing, since the deposit in Babbage era should be supplied on the pre-conway fashion: when balancing the transaction. So it would be good to remove the flag for Babbage era and legacy


Clarification here on Slack: --key-reg-deposit-amt should only be present in conway.

@smelc
Copy link
Contributor

smelc commented Dec 7, 2023

@CarlosLopezDeLara> PR is at #509

⚠️ The PR only changes the parser for babbage stake-address registration-certificate. I can't modify the legacy parser (no matter if the era is omitted, or if --babbage-era is passed). We're touching here the fundamental difference between the era based parser and the legacy ones: era based parsers can be made era-specific, while the legacy ones cannot (see discussion on Slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment