stake-address registration-certificate: do not allow key-reg-deposit-amt before conway

[smelc]

Changelog

- description: |
    `stake-address registration-certificate`: remove flag `--key-reg-deposit-amt` from all eras except conway
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #504

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carlhammann]

If I understand #504, and the function createRegistrationCertRequirements correctly, we can (should!) go even further. The --key-reg-deposit-amt flag should be present only on the Conway command line (and the legacy one, where we can't avoid it...), shouldn't it?

[carbolymer]

Couple of code style comments.

[carbolymer]

This code is a bit hard to follow and reason about. How about something simpler, using forEraInEonMaybe:

Suggested change

	(\babbageOnwards ->
	let babbageOrConway = babbageEraOnwardsToShelleyBasedEra babbageOnwards
	babbageBuilder si = StakeAddressRegistrationCertificateCmd babbageOrConway si Nothing
	conwayBuilder si lovelace = StakeAddressRegistrationCertificateCmd babbageOrConway si (Just lovelace)
	in make $ case babbageOnwards of
	BabbageEraOnwardsBabbage -> babbageBuilder <$> pStakeIdentifier <*> pOutputFile
	BabbageEraOnwardsConway -> conwayBuilder <$> pStakeIdentifier <*> pKeyRegistDeposit <*> pOutputFile
	)
	sbe
	where
	desc = Opt.progDesc "Create a stake address registration certificate"
	make parser = subParser "registration-certificate" (Opt.info parser desc)
	(\_babbageOnwards -> do
	let mpKeyRegistDeposit =
	sequenceA $ forEraInEonMaybe
	@ConwayEraOnwards
	era
	(const pKeyRegistDeposit)
	make $ StakeAddressRegistrationCertificateCmd sbe
	<$> pStakeIdentifier
	<*> mpKeyRegistDeposit
	<*> pOutputFile
	)
	sbe
	where
	desc = Opt.progDesc "Create a stake address registration certificate"
	make parser = subParser "registration-certificate" (Opt.info parser desc)

[smelc]

I went for something simpler in the new version, can you have another look?

[CarlosLopezDeLara]

legacy

That's correct. It's a conway only flag.

[Jimbo4350]

Why not pure Nothing for Shelley to Babbage??

[smelc]

Hum yeah really smart, I hadn't thought of lifting over the value type rather than the Parser type 👍

Done the change.

[Jimbo4350]

LGTM! Just squash the commits.

[smelc]