Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vote delegation in stake-address-info #452

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Nov 13, 2023

Changelog

- description: |
    add the vote delegateee to the output of `stake-address-info`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR closes #423.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann force-pushed the ch/show-vote-delegation branch 2 times, most recently from 1a47373 to f2037b5 Compare November 13, 2023 17:42
@carlhammann
Copy link
Contributor Author

carlhammann commented Nov 21, 2023

With last Friday's integration work on the node, this should now be usable with current main cardano-node. I'm therefore opening this for review. I'll release a new version of the cardano-api and revert 77bbc9d before merging; that should also solve the CI failures.

@carlhammann carlhammann added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit c2de167 Nov 23, 2023
20 checks passed
@carlhammann carlhammann deleted the ch/show-vote-delegation branch November 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stake-address-info to show drep-delegation
2 participants