Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node queries with tighter eons. Simplify prettyprinting. #481

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Use node queries with tighter eons. Simplify prettyprinting. #481

merged 1 commit into from
Nov 29, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Nov 24, 2023 •
edited
Loading

Changelog

- description: |
    Use node queries with tighter eons. Simplify prettyprinting.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR integrates latest API and requires:

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/guard-queries-with-eras branch 3 times, most recently from 629287a to 6ee70a6 Compare November 27, 2023 15:37
@carbolymer carbolymer changed the title Mgalazyn/feature/guard queries with eras Use node queries with tigher eons. Simplify prettyprinting. Nov 27, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feature/guard-queries-with-eras branch 2 times, most recently from 6df6127 to cdcc5a2 Compare November 28, 2023 16:14
@carbolymer carbolymer force-pushed the mgalazyn/feature/guard-queries-with-eras branch 2 times, most recently from 5a589b4 to 1b35a2b Compare November 28, 2023 17:26
@carbolymer carbolymer changed the title Use node queries with tigher eons. Simplify prettyprinting. Use node queries with tighter eons. Simplify prettyprinting. Nov 28, 2023
@carbolymer carbolymer force-pushed the mgalazyn/feature/guard-queries-with-eras branch from 1b35a2b to a50e19a Compare November 29, 2023 08:59
@carbolymer carbolymer force-pushed the mgalazyn/feature/guard-queries-with-eras branch from a50e19a to 005416b Compare November 29, 2023 08:59
@carbolymer carbolymer marked this pull request as ready for review November 29, 2023 08:59
@carbolymer carbolymer added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit c754fe3 Nov 29, 2023
21 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/guard-queries-with-eras branch November 29, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carbolymer @Jimbo4350