Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated textEnvelope type on registering a Stake Address Registration Certificate - Tests #499

Closed
wants to merge 6 commits into from

Conversation

felix-lipski
Copy link
Contributor

@felix-lipski felix-lipski commented Dec 4, 2023

Changelog

- description: |
    replace assertFileOccurance with asserHasMappings
    comment about certificate type
    golden tests for deregistration
    test registration on shelley to babbage eras
    update golden files
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Related to issue #465 in cardano-cli
Tests PR #390 in cardano-api

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@felix-lipski felix-lipski force-pushed the felix-lipski/fix/cert-conway-envelope-type branch 3 times, most recently from 1ed3991 to 88cb16e Compare December 7, 2023 17:42
@felix-lipski felix-lipski force-pushed the felix-lipski/fix/cert-conway-envelope-type branch from 88cb16e to f5955f9 Compare December 13, 2023 11:10
@smelc
Copy link
Contributor

smelc commented Jan 2, 2024

Probably superseded by #538

@smelc smelc closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants