Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links broken by migration #528

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 20, 2023

Changelog

- description: |
    Make it possible to merge again, by fixing dead links
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

A number of links have been made 404 by the GitHub migration, and as the CI checks links for validity, this is blocking merging.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • NA New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review December 20, 2023 16:17
@smelc smelc enabled auto-merge December 20, 2023 16:17
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik we should use domains within cardano.intersectmbo.org for api docs.

@smelc smelc force-pushed the smelc/update-links-broken-by-migration branch from 6e3e91a to caacd64 Compare December 22, 2023 09:18
@smelc
Copy link
Contributor Author

smelc commented Dec 22, 2023

@carbolymer> ready for rereview, only one link change in the end.

@smelc smelc added this pull request to the merge queue Dec 29, 2023
@carbolymer
Copy link
Contributor

Thanks @smelc!

Merged via the queue into main with commit 3ce0cf3 Dec 29, 2023
19 checks passed
@smelc smelc deleted the smelc/update-links-broken-by-migration branch December 29, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants