Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signing with drep extended key #556

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 8, 2024

Changelog

- description: |
    Support signing with drep extended key
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #547

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/add-drep-extended-key-signing-support branch 2 times, most recently from 92d3ad8 to 5d3b04a Compare January 9, 2024 08:36
@smelc smelc force-pushed the smelc/add-drep-extended-key-signing-support branch from 5d3b04a to 7b0c13b Compare January 19, 2024 13:40
@smelc smelc marked this pull request as ready for review January 19, 2024 13:40
@smelc smelc enabled auto-merge January 19, 2024 14:23
@smelc smelc added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 838609b Jan 19, 2024
19 checks passed
@smelc smelc deleted the smelc/add-drep-extended-key-signing-support branch January 19, 2024 15:07
@gitmachtl
Copy link
Contributor

gitmachtl commented Jan 19, 2024

@smelc
hi, did you also add the extended keys for commitee cold and hot keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cardano-cli 8.17.0.0 cannot sign with DRepExtendedSigningKey_ed25519_bip32
3 participants