Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #569: Back to cardano-api JSON for protocol parameters #572

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Jan 17, 2024

Changelog

- description: |
    Revert #569, where we tried to adapt the output of the `protocol-parameters` query to show all parameters in Conway, and which broke round-tripping and downstream requirements.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The discussion is in the post-merge commits of #569, and I propose we continue it there.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carlhammann carlhammann added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 59333dd Jan 17, 2024
17 checks passed
@carlhammann carlhammann deleted the ch/revert-568 branch January 17, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants