Add proposal hash check when creating info governance action

[palas]

Changelog

- description: |
    Add proposal hash check when creating `info` governance action
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way

Context

This is another step forward on addressing #882.

Previous related PR: #895

So far I have only added the check to governance action create-info. There are several other places where to add the check, but I thought I would have a round of review first, before propagating.

How to trust this PR

I adapted a test to validate the new functionality, and that gives me a lot of confidence. I would try to check that the code style is good, I didn't introduce any bugs, the parameter structure and names make sense, and the help is comprehensive and comprehensible.

This check disables HTTP schemas (and obviously FILE), because I have been told the spec says that only HTTPS and IPFS` are allowed. But I could not find where this is said. Could anybody confirm?

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[CarlosLopezDeLara]

Looks great to me!|

• As discussed, using either --check-anchor-data or --trust-anchor-data is mandatory.
• The error messages are clear.
• When the check is correct we have no news, so it's perfect!

cardano-cli conway governance action create-info (--mainnet | --testnet)
                                                          --governance-action-deposit NATURAL
                                                          ( --deposit-return-stake-verification-key STRING
                                                          | --deposit-return-stake-verification-key-file FILEPATH
                                                          | --deposit-return-stake-key-hash HASH
                                                          | --deposit-return-stake-script-file FILEPATH
                                                          | --deposit-return-stake-address ADDRESS
                                                          )
                                                          --anchor-url TEXT
                                                          --anchor-data-hash HASH
                                                          ( --check-anchor-data
                                                          | --trust-anchor-data
                                                          )
                                                          --out-file FILEPATH

 ./dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-cli-9.4.1.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance action create-info \
--testnet \
--governance-action-deposit 100000000000 \
--deposit-return-stake-verification-key-file ~/tests/example/utxo-keys/stake1.vkey \
--anchor-url https://raw.githubusercontent.com/carloslodelar/proposals/refs/heads/main/WrongURL.jsonld  \
--anchor-data-hash d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3dff \
--check-anchor-data \
--out-file ~/test-conway/testcheckmetadatahash.action
Command failed: governance action create-info  Error: Error while checking proposal hash: \
Bad status code when downloading anchor data: 404 (Not Found: 404: Not Found)

./dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-cli-9.4.1.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance action create-info \
--testnet \
--governance-action-deposit 100000000000 \
--deposit-return-stake-verification-key-file stake1.vkey \
--anchor-url https://c-ipfs-gw.nmkr.io/ipfs/QmXdfDSSkR8TYBntMT4nuTL9sE9E44FJnpWVpaY8ZTfwjj \
--anchor-data-hash d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3d5f \
--check-anchor-data \
--out-file ~/test-conway/testcheckmetadatahash.action

Command failed: governance action create-info  Error: Hashes do not match while checking proposal hashes! 
Expected: "d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3d5f"
  Actual: "d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3dff"

./dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-cli-9.4.1.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance action create-info \
--testnet \
--governance-action-deposit 100000000000 \
--deposit-return-stake-verification-key-file ~/tests/example/utxo-keys/stake1.vkey \
--anchor-url https://c-ipfs-gw.nmkr.io/ipfs/WrongURL  \
--anchor-data-hash d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3dff \
--check-anchor-data \
--out-file ~/test-conway/testcheckmetadatahash.action
Command failed: governance action create-info  
Error: Error while checking proposal hash: Bad status code when downloading anchor data: 400 
(Bad Request: invalid ipfs path: invalid path "/ipfs/WrongURL": 
invalid CID: selected encoding not supported)

Failing to use the any of the flags

./dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-cli-9.4.1.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance action create-info --testnet --governance-action-deposit 100000000000 --deposit-return-stake-verification-key-file ~/tests/example/utxo-keys/stake1.vkey --anchor-url https://raw.githubusercontent.com/carloslodelar/proposals/refs/heads/main/WrongURL.jsonld  --anchor-data-hash d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3dff --out-file ~/test-conway/testcheckmetadatahash.action
Missing: (--check-anchor-data | --trust-anchor-data)

Using http

./dist-newstyle/build/x86_64-linux/ghc-8.10.7/cardano-cli-9.4.1.0/x/cardano-cli/build/cardano-cli/cardano-cli conway governance action create-info --testnet --governance-action-deposit 100000000000 --deposit-return-stake-verification-key-file ~/tests/example/utxo-keys/stake1.vkey --anchor-url http://raw.githubusercontent.com/carloslodelar/proposals/refs/heads/main/WrongURL.jsonld  --anchor-data-hash d4efa9e0c3d80f5be35def08551eaf5aef17eae832fdb835e5f4b208d98f3dff --check-anchor-data \--out-file ~/test-conway/testcheckmetadatahash.action
Command failed: governance action create-info  Error: Error while checking proposal hash: 
Unsupported URL scheme: http:

[CarlosLopezDeLara]

LGTM!

[CarlosLopezDeLara]

Want to give this a try, @Crypto2099?