Updates cardano-cli to not use PReferenceScript/SReferenceScript ScriptHash field

[Swordlash]

Changelog

- description: Updates cardano-cli to not use PReferenceScript/SReferenceScript ScriptHash field
  type:
  - compatible
  - refactoring

Context

See the upstream PR.
The Maybe ScriptHash field in P/SReferenceScript is redundant in cardano-api, causing confusion. Nonetheless it's used in cardano-cli as a temporary container for user-provided input. This PR refactors it out so the field can be safely removed from upstream.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[smelc]

Suggested change

	gatherMintingWitnesses ((pid'm, sWit) : rest) =
	case scriptWitnessPolicyId pid'm sWit of
	gatherMintingWitnesses ((mPid, sWit) : rest) =
	case scriptWitnessPolicyId mPid sWit of

Rationale: having a quote in the middle of a variable name is surprising

[Swordlash]

I picked up this style in Standard Chartered ('m for Maybe, 'e for Either). No issue, I will adhere to suggested style.

[Swordlash]

All updated, squashed and formatted.

[smelc]

@Swordlash> please format your changes with:

fourmolu -i ...modified hs files...
stylish-haskell -i ...modified hs files...

(in this order: fourmolu first, then stylish-haskell)

[Jimbo4350]

@Swordlash thank you for bringing this to our attention. I have been aware of this for some time but haven't been able to dedicate the time to a solution. We're discussing a potential solution that involves modifying the cardano-api and avoids introducing Maybe PolicyId as it's done here. I've asked @carbolymer to work on it.

[Jimbo4350]

We are discussing another way to modify cardano-api to avoid having to specify Maybe PolicyId.

[Swordlash]

Thanks @Jimbo4350, lmk if you'd like me to do something, I'm prepared to dedicate some time for it this week (next weeks I'm away).