Rework the CI #551
Closed
Rework the CI #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the CI to give more control to GitHub Actions. - The flake exposes the list of smoke-test derivations that GHA load and execute. - The repositories for base (available only for PRs) and head are built concurrently - Built repositories are cached by their commit hash, we should not need to build them more than once. We can always delete the specific cache in case of issues. Minor changes: - haskellPackages -> chapPackages - Consistent camelCase - chapPackagesLatestVersion maps to a single version rather than a list with a single element Bump flake
andreabedini
force-pushed
the
andrea/rework-ci
branch
from
9d2f4a1 to
79fad13
Compare
michaelpj
reviewed
Nov 8, 2023
| # include: | ||
| # - name: ghc96/cardano-node/8.5.0 | ||
| # ... | ||
| matrix: ${{ fromJSON(needs.generate-smoke-tests.outputs.matrix) }} |
There was a problem hiding this comment.
This is not a good idea, I'm afraid. The reason is that there is a cap on the maximum number of jobs that a matrix can generate :( I ran into this trying to do something like this for HLS. I think we would hit the cap quite fast (it's ~500). We could potentially do one job per GHC version I guess.
michaelpj
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Just a comment on the main approach. Also, we did something like this in the past, I think, and I moved it to just build the smoke test packages derivation because we wanted to do less in GHA. But I do think it can be nice to do more in GHA if we get a better UI from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the CI to give more control to GitHub Actions.
Minor changes:
Opening as draft to see if it works.