Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Incremental Lambda Calculus, tests, and benchmarks #3344

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Introduce Incremental Lambda Calculus, tests, and benchmarks #3344

wants to merge 3 commits into from

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Mar 21, 2023 •
edited by JaredCorduan
Loading

This adds code for the incremental lambda calculus. Data.Incremental. It also adds some property tests and one benchmark to demonstrate we can compute stake and other distributions incrementally.

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

edit from @JaredCorduan - note that this technique would solve #3034

JaredCorduan
JaredCorduan approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exciting stuff! The names are maybe a bit terse, but the ideas are awesome.

lehins
lehins approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various suggestions.
This is a really good start!

libs/cardano-data/src/Data/Incremental.hs Outdated Show resolved Hide resolved
libs/cardano-data/src/Data/Incremental.hs Outdated Show resolved Hide resolved
libs/cardano-data/src/Data/Incremental.hs Outdated Show resolved Hide resolved
libs/cardano-data/src/Data/Incremental.hs Outdated Show resolved Hide resolved
libs/cardano-data/testlib/Test/Cardano/Data.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/bench/Bench/Cardano/Ledger/Incremental.hs Show resolved Hide resolved
libs/cardano-data/testlib/Test/Cardano/Data.hs Outdated Show resolved Hide resolved
libs/cardano-data/testlib/Test/Cardano/Data.hs Outdated Show resolved Hide resolved
libs/cardano-data/testlib/Test/Cardano/Data.hs Outdated Show resolved Hide resolved
libs/cardano-data/test/Test/Cardano/Data/Incremental.hs Outdated Show resolved Hide resolved
@IntersectMBO IntersectMBO deleted a comment from lehins Mar 24, 2023
@lehins
Copy link
Collaborator

lehins commented Mar 24, 2023 •
edited
Loading

FYI, new cabal target was added, so you need to run ./scripts/gen-hie.sh

@JaredCorduan JaredCorduan marked this pull request as draft May 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@teodanciu teodanciu teodanciu left review comments

@lehins lehins lehins approved these changes

@aniketd aniketd Awaiting requested review from aniketd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimSheard @lehins @JaredCorduan @teodanciu