Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CDDL via Huddle in shelley-ma #4557

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Define CDDL via Huddle in shelley-ma #4557

wants to merge 13 commits into from

Commits on Aug 19, 2024

  1. Move extras and crypto types to core CDDL

    Now that the CDDL is defined with Cuddle, we can
    begin to properly modularise it. As a first step,
    we move the common crypto and utility types into
    the core package.
    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a9488c View commit details
    Browse the repository at this point in the history
  2. Define Shelley CDDL via Huddle

    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ed05a18 View commit details
    Browse the repository at this point in the history
  3. Generate Shelley CDDL using Huddle.

    - Switch existing tests to using the generated CDDL
    - Add additional Huddle based tests for Shelley types
    - Add a tool to regenerate the Shelley CDDL from Huddle
    - Move additional core types to the core CDDL
    - Make a few fixes in the Shelley Huddle spec
    
    There is one unusual thing here: the size bound on
    the max block header size in the protocol param
    update. This does not reflect the original CDDL,
    but it is consistent with the FromCBOR instance
    and the underlying data type in PParams. I can
    only assume that the CDDL generator wasn't
    exploring the whole range and thus never found
    this error.
    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    830e1c4 View commit details
    Browse the repository at this point in the history
  4. Use common CDDL definitions from Shelley.

    Now that Shelley is defined using Huddle, we can
    rely on the relevant parts from Conway.
    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    529bdd3 View commit details
    Browse the repository at this point in the history
  5. Fourmolu

    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    16106f4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c7954d View commit details
    Browse the repository at this point in the history
  7. Update hie file.

    nc6 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f87081c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Reintroduce detailed comments in CDDL.

    We use 'here' QuasiQuotes to make handling
    multiline comments somewhat less painful.
    nc6 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    abeb131 View commit details
    Browse the repository at this point in the history
  2. Add a CDDL root element.

    This addresses issue #4535. The first rule in a
    CDDL file is taken to be the root element.
    nc6 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bd29e18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1759af1 View commit details
    Browse the repository at this point in the history
  4. Define CDDL for Allegra in Huddle.

    Includes tests and generation utility.
    nc6 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9ea8ff4 View commit details
    Browse the repository at this point in the history
  5. Define CDDL for Mary in Huddle.

    Also includes testing and cddl generation tool.
    nc6 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8c36768 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bcd26f0 View commit details
    Browse the repository at this point in the history