Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch type for predicate failures #4649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Sep 27, 2024

Description

This is the first part of #4619. After this the priority is to first get Conway predicates to use the new Mismatch type, and then the rest of the remaining eras.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd marked this pull request as ready for review September 27, 2024 14:49
@aniketd aniketd requested a review from a team as a code owner September 27, 2024 14:49
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@aniketd I'll review it again once you address all the comments, but you can already start on integrating Mismatch into Conway predicate failures using this PR

eras/shelley/impl/CHANGELOG.md Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/BaseTypes.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Bbody.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Bbody.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/mismatch-type-for-predicate-failures branch from d16faba to d3d18ee Compare October 2, 2024 17:32
@aniketd aniketd requested a review from lehins October 2, 2024 17:32
@aniketd aniketd force-pushed the aniketd/mismatch-type-for-predicate-failures branch from d3d18ee to 8d4867e Compare October 2, 2024 17:44
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better, but there is still one small mistake.

@aniketd aniketd force-pushed the aniketd/mismatch-type-for-predicate-failures branch from 8d4867e to 3a7405d Compare October 4, 2024 10:58
@aniketd aniketd requested a review from lehins October 4, 2024 10:59
@aniketd aniketd force-pushed the aniketd/mismatch-type-for-predicate-failures branch from 3a7405d to 05c15f8 Compare October 4, 2024 11:09
@lehins lehins force-pushed the aniketd/mismatch-type-for-predicate-failures branch from 05c15f8 to 87dba8f Compare October 4, 2024 14:52
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants