Skip to content

wb | enable cardano-profile #8433

wb | enable cardano-profile

wb | enable cardano-profile #8433

Triggered via pull request October 2, 2024 13:09
@fmastefmaste
synchronize #5994
bench-jq
Status Success
Total duration 56s
Artifacts

check-hlint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build: bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L124
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', BFT, 0, True)" ▫︎ Perhaps: "(, BFT, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
build: bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L152
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', Proxy, 0, True)" ▫︎ Perhaps: "(, Proxy, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
build: bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L165
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', ChaindbServer, 0, True)" ▫︎ Perhaps: "(, ChaindbServer, 0, True)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
build: bench/cardano-profile/src/Cardano/Benchmarking/Profile/NodeSpecs.hs#L178
Suggestion in nodeSpecs' in module Cardano.Benchmarking.Profile.NodeSpecs: Use tuple-section ▫︎ Found: "\\ i' -> (i', Explorer, 0, False)" ▫︎ Perhaps: "(, Explorer, 0, False)" ▫︎ Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file
build: bench/cardano-profile/src/Cardano/Benchmarking/Profile/Builtin/Empty.hs#L154
Suggestion in profilesNoEraEmpty in module Cardano.Benchmarking.Profile.Builtin.Empty: Use : ▫︎ Found: "[ciTestHydra\n & P.name \"ci-test-hydra\"\n . V.plutusLoop . P.traceForwardingOn . P.newTracing . P.p2pOn]\n ++\n let\n trace\n = P.empty\n & V.datasetEmpty\n . genesis\n . P.torus\n . V.hosts 6 . P.loopback . P.tracerWithresources . V.clusterDefault\n bench = trace & traceBenchDuration\n full = trace & traceFullDuration\n in\n [bench\n & P.name \"trace-bench\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview,\n bench\n & P.name \"trace-bench-oldtracing\"\n . V.valueLocal . P.traceForwardingOn . P.oldTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-notracer\"\n . V.valueLocal . P.traceForwardingOff . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview]\n ++\n let\n noCliStop\n = P.empty\n & defaultDuration\n . P.uniCircle\n . V.hosts 6\n . P.loopback\n . P.utxo 0 . P.delegators 6 . P.dreps 0 . V.clusterDefault\n value = noCliStop & V.genesisVariant300\n plutus = noCliStop & V.genesisVariantPreVoltaire\n loop = V.plutusLoop\n ecdsa = V.plutusSaturation . V.plutusTypeECDSA\n schnorr = V.plutusSaturation . V.plutusTypeSchnorr\n in\n [value\n & P.name \"default\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.newTracing . P.p2pOff . P.analysisUnitary,\n value\n & P.name \"default-p2p\"\n . V.valueCloud\n . P.traceForwardingOn . P.newTracing . P.p2pOn . P.analysisUnitary,\n value\n & P.name \"oldtracing\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.oldTracing . P.p2pOff . P.analysisUnitary,\n plutus\n & P.name \"plutus\"\n . loop . P.traceForwardingOn . P.newTracing . P.p2pOff,\n plutus\n & P.name \"plutus-secp-ecdsa\"\n . ecdsa . P.traceForwardingOn . P.newTracing . P.p2pOff,\n plutus\n & P.name \"plutus-secp-schnorr\"\n . schnorr . P.traceForwardingOn . P.newTracing . P.p2pOff]\n ++\n let\n ep\n = P.empty\n & V.datasetEmpty\n . genesis\n . epochTransitionDuration\n . P.uniCircle . V.hosts 2 . P.loopback . V.clusterDefault\n in\n [ep\n & P.name \"epoch-transition\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff]" ▫︎ Perhaps: "(ciTestHydra\n & P.name \"ci-test-hydra\"\n . V.plutusLoop . P.traceForwardingOn . P.newTracing . P.p2pOn)\n : let\n trace\n = P.empty\n & V.datasetEmpty\n . genesis\n . P.torus\n . V.hosts 6 . P.loopback . P.tracerWithresources . V.clusterDefault\n bench = trace & traceBenchDuration\n full = trace & traceFullDuration\n in\n [bench\n & P.name \"trace-bench\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview,\n bench\n & P.name \"trace-bench-oldtracing\"\n . V.valueLocal . P.traceForwardingOn . P.oldTracing . P.p2pOff,\n bench\n & P.name \"trace-bench-notracer\"\n . V.valueLocal . P.traceForwardingOff . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full\"\n . V.valueLocal . P.traceForwardingOn . P.newTracing . P.p2pOff,\n full\n & P.name \"trace-full-rtview\"\n . V.valueLocal\n . P.traceForwardingOn . P.newTracing . P.p2pOff . P.tracerRtview]\n ++\n let\n noCliStop\n = P.empty\n & defaultDuration\n . P.uniCircle\n . V.hosts 6\n . P.loopback\n . P.utxo 0 . P.delegators 6 . P.dreps 0 . V.clusterDefault\n value = noCliStop & V.genesisVariant300\n plutus = noCliStop & V.genesisVariantPreVoltaire\n loop = V.plutusLoop\n ecdsa = V.plutusSaturation . V.plutusTypeECDSA\n schnorr = V.plutusSaturation . V.plutusTypeSchnorr\n in\n [value\n & P.name \"default\"\n . V.valueCloud\n . P.traceForwardingOn\n . P.newTracing . P.p2pOff . P.analysisUnitary,\n value\n & P.name \"default-p2p\"\n . V.valueCloud\n . P.traceForwardingOn . P.newTracing . P.p2pOn . P.analysisUnitary,\n value\n & P.name \"oldtracing\"\n . V.valu
build: bench/cardano-topology/app/cardano-topology.hs#L82
Suggestion in getOpts in module Main: Move brackets to avoid $ ▫︎ Found: "(hsubparser\n $ command\n \"make\"\n (info\n (Make <$> cliParserMake)\n (fullDesc\n <> header \"make\" <> progDesc \"Create a cluster topology\"))\n <>\n command\n \"projection-for\"\n (info\n (ProjectionFor\n <$>\n strOption\n (long \"topology-input\"\n <> help \"Topology file\" <> metavar \"INPUTFILE\")\n <*> cliParserProjection)\n (fullDesc\n <>\n header \"projection-for\"\n <> progDesc \"Create an individual topology\")))\n <**> helper" ▫︎ Perhaps: "hsubparser\n (command\n \"make\"\n (info\n (Make <$> cliParserMake)\n (fullDesc\n <> header \"make\" <> progDesc \"Create a cluster topology\"))\n <>\n command\n \"projection-for\"\n (info\n (ProjectionFor\n <$>\n strOption\n (long \"topology-input\"\n <> help \"Topology file\" <> metavar \"INPUTFILE\")\n <*> cliParserProjection)\n (fullDesc\n <>\n header \"projection-for\"\n <> progDesc \"Create an individual topology\")))\n <**> helper"
build: bench/cardano-topology/src/Cardano/Benchmarking/Topology/Projection.hs#L56
Suggestion in NetworkTopology in module Cardano.Benchmarking.Topology.Projection: Use newtype instead of data ▫︎ Found: "data NetworkTopology\n = RealNodeTopology ![RemoteAddress]\n deriving (Eq, Show)" ▫︎ Perhaps: "newtype NetworkTopology\n = RealNodeTopology [RemoteAddress]\n deriving (Eq, Show)"
build: bench/cardano-topology/test/Cardano/Benchmarking/Topology/Projection/Tests.hs#L33
Warning in projection in module Cardano.Benchmarking.Topology.Projection.Tests: Evaluate ▫︎ Found: "map\n (\\ (topologyName, projections)\n -> Tasty.testGroup topologyName\n $ map\n (\\ (projectionId, projectionName)\n -> testCase projectionName\n $ do let topologyDir = \"data/test/\" ++ topologyName ++ \"/\"\n let projectionDir = topologyDir\n topologyPath <- Paths.getDataFileName\n $ topologyDir ++ \"topology.json\"\n projectionPath <- Paths.getDataFileName\n $ projectionDir ++ projectionName\n eitherTopology <- Aeson.eitherDecodeFileStrict topologyPath\n eitherProjection <- Aeson.eitherDecodeFileStrict projectionPath\n case (eitherTopology, eitherProjection) of\n (Right topology, Right proj)\n -> assertEqual\n (\"node-specs.json == (nodeSpecs \\\"\" ++ topologyName ++ \"\\\")\")\n proj (Projection.projection topology projectionId 30000)\n errors -> fail (show errors))\n projections)\n [(\"ci-test-coay\", [(0, \"node-0.json\"), (1, \"node-1.json\")])]" ▫︎ Perhaps: "[(\\ (topologyName, projections)\n -> Tasty.testGroup topologyName\n $ map\n (\\ (projectionId, projectionName)\n -> testCase projectionName\n $ do let topologyDir = \"data/test/\" ++ topologyName ++ \"/\"\n let projectionDir = topologyDir\n topologyPath <- Paths.getDataFileName\n $ topologyDir ++ \"topology.json\"\n projectionPath <- Paths.getDataFileName\n $ projectionDir ++ projectionName\n eitherTopology <- Aeson.eitherDecodeFileStrict topologyPath\n eitherProjection <- Aeson.eitherDecodeFileStrict projectionPath\n case (eitherTopology, eitherProjection) of\n (Right topology, Right proj)\n -> assertEqual\n (\"node-specs.json == (nodeSpecs \\\"\" ++ topologyName ++ \"\\\")\")\n proj (Projection.projection topology projectionId 30000)\n errors -> fail (show errors))\n projections)\n (\"ci-test-coay\", [(0, \"node-0.json\"), (1, \"node-1.json\")])]"
build: bench/cardano-topology/test/Cardano/Benchmarking/Topology/Projection/Tests.hs#L65
Warning in projectionP2P in module Cardano.Benchmarking.Topology.Projection.Tests: Evaluate ▫︎ Found: "map\n (\\ (topologyName, projections)\n -> Tasty.testGroup topologyName\n $ map\n (\\ (projectionId, projectionName)\n -> testCase projectionName\n $ do let topologyDir = \"data/test/\" ++ topologyName ++ \"/\"\n let projectionDir = topologyDir\n topologyPath <- Paths.getDataFileName\n $ topologyDir ++ \"topology.json\"\n projectionPath <- Paths.getDataFileName\n $ projectionDir ++ projectionName\n eitherTopology <- Aeson.eitherDecodeFileStrict topologyPath\n eitherProjection <- Aeson.eitherDecodeFileStrict projectionPath\n case (eitherTopology, eitherProjection) of\n (Right topology, Right projP2P)\n -> assertEqual\n (\"node-specs.json == (nodeSpecs \\\"\" ++ topologyName ++ \"\\\")\")\n projP2P (Projection.projectionP2P topology projectionId 30000)\n errors -> fail (show errors))\n projections)\n [(\"value-volt-nomadperf-coay\", \n [(0, \"node-0.json\"), (1, \"node-1.json\"), (2, \"node-2.json\"),\n (3, \"node-3.json\"), (4, \"node-4.json\"), (5, \"node-5.json\"),\n (6, \"node-6.json\"), (7, \"node-7.json\"), (8, \"node-8.json\"),\n (9, \"node-9.json\"), (10, \"node-10.json\"), (11, \"node-11.json\")])]" ▫︎ Perhaps: "[(\\ (topologyName, projections)\n -> Tasty.testGroup topologyName\n $ map\n (\\ (projectionId, projectionName)\n -> testCase projectionName\n $ do let topologyDir = \"data/test/\" ++ topologyName ++ \"/\"\n let projectionDir = topologyDir\n topologyPath <- Paths.getDataFileName\n $ topologyDir ++ \"topology.json\"\n projectionPath <- Paths.getDataFileName\n $ projectionDir ++ projectionName\n eitherTopology <- Aeson.eitherDecodeFileStrict topologyPath\n eitherProjection <- Aeson.eitherDecodeFileStrict projectionPath\n case (eitherTopology, eitherProjection) of\n (Right topology, Right projP2P)\n -> assertEqual\n (\"node-specs.json == (nodeSpecs \\\"\" ++ topologyName ++ \"\\\")\")\n projP2P (Projection.projectionP2P topology projectionId 30000)\n errors -> fail (show errors))\n projections)\n (\"value-volt-nomadperf-coay\", \n [(0, \"node-0.json\"), (1, \"node-1.json\"), (2, \"node-2.json\"),\n (3, \"node-3.json\"), (4, \"node-4.json\"), (5, \"node-5.json\"),\n (6, \"node-6.json\"), (7, \"node-7.json\"), (8, \"node-8.json\"),\n (9, \"node-9.json\"), (10, \"node-10.json\"), (11, \"node-11.json\")])]"
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/