Remove openssl support for snap-serer #5973
Conversation
Disable HsOpenSSL support for snap-server. HsOpenSSL already fails
to compile with GCC versons >= 14.2 and will like stop working all
together earlu in 2025:
haskell-cryptography/HsOpenSSL#95
erikd
force-pushed
the
erikd/ghc-9.10
branch
from
2050f12
to
308bb7b
Compare
| flags: +openssl | ||
| -- OpenSSL support requires HsOpenSSL which will cause problems in the near future | ||
| -- https://github.com/haskell-cryptography/HsOpenSSL/issues/95 | ||
| flags: -openssl |
There was a problem hiding this comment.
Unless snap-server remains somewhere in the node's dependency graph, this flag from now on only affects cardano-tracer. That, however, will need to account for a non-default, non-SSL build of its dependency within the application code.
Merging this flag change would break cardano-tracer currently, please remove and postpone.
There was a problem hiding this comment.
This currently builds with this change.
The -openssl flag on enables SSL for cardano-tracer when cardano-tracer is built with the -rtview flag which is not on be default.
There was a problem hiding this comment.
Flags -openssl and +rtview result in a broken service (i.e., unable to start up). Handling this case needs to be adjusted in the application code before any merge.
|
Closing this in favor of #5975 which will contain the same changes plus necessary application-side adjustements - removing the dependency on |
Description
OpenSSL support was only need by
cardano-tracerand even then is only used whencardano-traceris compiled with thertviewflag isTrue(by defaultFalse).Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.