Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-tracer: Fix multiple empty logs being produced. #6002

Merged
merged 1 commit into from
Oct 2, 2024
Merged

cardano-tracer: Fix multiple empty logs being produced. #6002

merged 1 commit into from
Oct 2, 2024
+33 −33

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented Oct 2, 2024 •
edited
Loading

Description

Prevented creation of empty logs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@Icelandjack Icelandjack requested review from a team as code owners October 2, 2024 08:38
@Icelandjack Icelandjack force-pushed the cardano-tracer-logrotate branch 4 times, most recently from 4530aa9 to ee08096 Compare October 2, 2024 10:37
mgmeier
mgmeier approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Icelandjack

@mgmeier mgmeier enabled auto-merge October 2, 2024 11:10
@mgmeier mgmeier added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 950659e Oct 2, 2024
25 checks passed
@mgmeier mgmeier deleted the cardano-tracer-logrotate branch October 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icelandjack @mgmeier