Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ccMinSize check #514

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix ccMinSize check #514

merged 1 commit into from
Aug 30, 2024

Conversation

WhatisRT
Copy link
Collaborator

Description

Closes #508.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@jmchapman
Copy link

Can this be reviewed even though it's waiting for something?

@WhatisRT
Copy link
Collaborator Author

The issue is that there is another bug with that code, so this probably needs to be thrown away anyway.

@WhatisRT WhatisRT changed the title DO NOT MERGE: Fix ccMinSize check Fix ccMinSize check Aug 30, 2024
@WhatisRT
Copy link
Collaborator Author

Merging this now, we need to fix the other issue later.

@Soupstraw Soupstraw enabled auto-merge (rebase) August 30, 2024 10:25
@Soupstraw Soupstraw merged commit 1d77a35 into master Aug 30, 2024
3 checks passed
@Soupstraw Soupstraw deleted the andre/fix-ratify branch August 30, 2024 10:25
github-actions bot added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activeCC does not double-count
3 participants