Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance when adding epochs #554

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 27, 2024

Description

Adding Epochs using _+ᵉ_ is currently very slow because it's operating on Peano numbers. This PR adds a more efficient addition function for adding epochs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/enact-conformance branch 5 times, most recently from 9d2c301 to 00650b8 Compare August 27, 2024 14:40
@Soupstraw Soupstraw changed the title DO NOT MERGE: Disabling committee updates for testing a performance issue Improved performance when adding epochs Aug 27, 2024
@Soupstraw Soupstraw marked this pull request as ready for review August 27, 2024 15:01
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhatisRT WhatisRT merged commit f5cf210 into master Aug 28, 2024
2 checks passed
@WhatisRT WhatisRT deleted the jj/enact-conformance branch August 28, 2024 09:43
github-actions bot added a commit that referenced this pull request Aug 28, 2024
@Lucsanszky Lucsanszky restored the jj/enact-conformance branch August 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants