Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conway changes not visible in PDF #556

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

williamdemeo
Copy link
Contributor

Description

This closes issue #536.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@williamdemeo williamdemeo linked an issue Aug 27, 2024 that may be closed by this pull request
2 tasks
@williamdemeo
Copy link
Contributor Author

This PR adds the new figure (pictured below) showing some changes that were missing from the Conway pdf.

Conway-new-figure

, updateDeposits pp txb deposits
, donations + txdonation
⟧ᵘ
Γ ⊢ s ⇀⦇ tx ,UTXOS⦈ ⟦ (utxo ∣ txins ᶜ) ∪ˡ (outs txb) , fees + txfee , updateDeposits pp txb deposits , donations + txdonation ⟧ᵘ
Copy link
Contributor Author

@williamdemeo williamdemeo Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simple mod (and a similar one below) greatly improves the agda2vec post-processing for vertical vectors. (In fact, when the ⟦...⟧ᵘ expression is spread across multiple lines, the agda2vec produces latex code that doesn't compile. This is nontrivial to fix so, for now, let's keep the ⟦...⟧ᵘ expression on a single line.)

…m:IntersectMBO/formal-ledger-specifications into 536-conway-changes-not-visible-in-the-pdf
@williamdemeo
Copy link
Contributor Author

The figure shown below is not new, but this PR includes it in the Conway pdf, along with a brief explanation. The \begin{NoConway}...\end{NoConway} tags that had surrounded the figure were removed.

Conway-utxo-new-fig

Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhatisRT WhatisRT merged commit d569906 into master Aug 28, 2024
3 checks passed
@WhatisRT WhatisRT deleted the 536-conway-changes-not-visible-in-the-pdf branch August 28, 2024 09:33
github-actions bot added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conway changes not visible in the PDF
2 participants