Test roundtrips of snapshot metadata to disk with FS error injection #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
This mainly includes `bracket`-style combinators for setting up a simulated file system and blockio-uring instance, and checking some properties on the mocked file system automatically.
This means we clean up the named snapshot directory correctly in case something goes wrong
jorisdral
force-pushed
the
jdral/fault-roundtrip-snapshot-metadata
branch
3 times, most recently
from
ea64dbd to
ea64f39
Compare
This test is similar to the roundtrip test we already had, but now we test that the roundtrip holds even if there was a disk exception at some point, in particular during the part where we write metadata files to disk.
jorisdral
force-pushed
the
jdral/fault-roundtrip-snapshot-metadata
branch
from
ea64f39 to
3538bff
Compare
recursion-ninja
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.