Release a RefTracker even if the corresponding finaliser threw an error
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debug mode if the finaliser of a reference counted object throws an error, then the `RefTracker` is never released. `checkForgottenRefs` will then report the reference as forgotten, even though the finaliser ran, though not successfully. The test that is added in this commit indeed shows this is the case. The next commit fixes the issue, which should improve the experience of debugging finalisers that fail.
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/release-reftracker-exception
branch
2 times, most recently
from
c43a654 to
0c8bac8
Compare
dcoutts
approved these changes
Jan 7, 2025
jorisdral
force-pushed
the
jdral/release-reftracker-exception
branch
from
0c8bac8 to
2880e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode if the finaliser of a reference counted object throws an error, then the
RefTrackeris never released.checkForgottenRefswill then report the reference as forgotten, even though the finaliser ran, though not successfully. This PR ensures that theRefTrackeris released even if the finaliser throw an error. This improves the experience of debugging finalisers that fail.