Remove circular symlink from language-plutus-core #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Option c) Add some TH magic so it can detect HIE. Takes too long IMO. |
|
I don't understand what goes wrong with HIE. Can you elaborate? If it doesn't build when it works with both stack and cabal that's IMO a bug in HIE. |
|
Yeah, it's a bug. I reported it here: fpco/th-utilities#10 May also be a HIE bug. But as bugs go, it's fairly easy to work around. |
|
Okay, well there's no point having the file-embed stuff then. |
michaelpj
force-pushed
the
fix/lpc-symlink
branch
from
364f973 to
253d3f2
Compare
|
Fixed. |
reactormonk
approved these changes
Apr 15, 2020
It helps a tiny bit, but that's about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and this works fine with:
cabal teststack testnix build