StripMetaModifier::class

[deluxetom]

Going to keep it as draft, I'm going to update the encoders next

[deluxetom]

@olivervogel I'm not sure this is the best way to remove exif, I followed the example:
https://github.com/libvips/php-vips/blob/master/examples/keep.php

[olivervogel]

@olivervogel I'm not sure this is the best way to remove exif, I followed the example: https://github.com/libvips/php-vips/blob/master/examples/keep.php

Does the strip option in the writeToBuffer() call remove icc as well?

[deluxetom]

@olivervogel I'm not sure this is the best way to remove exif, I followed the example: https://github.com/libvips/php-vips/blob/master/examples/keep.php

Does the strip option in the writeToBuffer() call remove icc as well?

I believe it does strip all metadata (icc, exif, xmp, iptc)

[olivervogel]

I think we should ditch the modifier here and use the output options strip and keep for writeToBuffer().

$strip = $this->strip || (is_null($this->strip) && $this->driver()->config()->strip);

$result = $image->core()->native()->writeToBuffer('.avif', [
            'Q' => $this->quality,
            'strip' => $strip,
             'keep' => Vips\ForeignKeep::ICC,
        ]);

Not sure if this works in combination though. Maybe keep means that every meta data is removed except the given value(s).

[deluxetom]

@olivervogel I think we can keep both, the modifier and the strip encoder option.
I believe the modifier can be used before other operations and the ICC profile needs to be kept for the encoder (there can be color changes otherwise)

I just pushed the changes for the Jpeg encoder, let me know what you think

[olivervogel]

This would remove icc as well. Shouldn't the profile be retained?

[deluxetom]

I think its better to keep the ICC profiles as well, I'll make the changes

[olivervogel]

Very nice.