-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new matched aliases population #239
base: dev
Are you sure you want to change the base?
Conversation
7fd95d6
to
e5972c4
Compare
@@ -104,10 +104,11 @@ export const IdentifyAliasesScreenInvoice = () => { | |||
useEffect(() => { | |||
if (isSuccess) { | |||
if (processedInvoice) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will always be true - if the type is right. An empty object is truthy. I know it wasn't added here but it's your change that I didn't review that well hehe
@@ -120,6 +121,7 @@ export const IdentifyAliasesScreenInvoice = () => { | |||
newMatched[record.id] = { price_per_unit, quantity, product_id }; | |||
} | |||
|
|||
console.log({ newMatched, resolvedAliases }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delet dis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so the convention has been for the -response.json files to contain the raw azure response, not the edge function response, maybe let's rename it somehow
…ack/invtrack into fix-new-matched-aliases-population
b74b67e
to
e627fdb
Compare
No description provided.