Fix new matched aliases population #239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-lipski
force-pushed
the
fix-new-matched-aliases-population
branch
from
7fd95d6
to
e5972c4
Compare
| @@ -104,10 +104,11 @@ export const IdentifyAliasesScreenInvoice = () => { | |||
| useEffect(() => { | |||
| if (isSuccess) { | |||
| if (processedInvoice) { | |||
There was a problem hiding this comment.
this will always be true - if the type is right. An empty object is truthy. I know it wasn't added here but it's your change that I didn't review that well hehe
| @@ -120,6 +121,7 @@ export const IdentifyAliasesScreenInvoice = () => { | |||
| newMatched[record.id] = { price_per_unit, quantity, product_id }; | |||
| } | |||
|
|
|||
| console.log({ newMatched, resolvedAliases }); | |||
michalstruck
requested changes
Jul 13, 2024
There was a problem hiding this comment.
Wait, so the convention has been for the -response.json files to contain the raw azure response, not the edge function response, maybe let's rename it somehow
…ack/invtrack into fix-new-matched-aliases-population
felix-lipski
force-pushed
the
fix-new-matched-aliases-population
branch
from
b74b67e
to
e627fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.