-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authentication tests #40
Open
snebo
wants to merge
11
commits into
main
Choose a base branch
from
unitTesting_admin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…backend into unitTesting_admin
…unitTesting_admin
snebo
requested review from
Tonykaynoni,
willypelz,
sirkenedy,
oyedeletemitope,
DennisTemoye,
auscay and
onochukwu
November 9, 2024 19:58
willypelz
requested changes
Nov 27, 2024
Tonykaynoni
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test implementation for AuthController
this pull request is designed to include tests for the AuthController and is focused on authentication-related functionalities (ie registration, login, password reset, and email verification token resending).
AuthController and AuthService are imported and injected, and controller routes are tested directly, bypassing the database by using mocked methods on the user schema. Mocks are also made for Authservice, JwtService, and UserModel to simulate authentication behaviors.
Testing Approach
Why did i mock static methods on the user schema?
simple, it kept fri**ing calling redis and Mongoose ser-...-cough
The User schema contains several static methods (signUp, verifyEmail, forgetPassword, etc.) used for core user actions in the authentication flow. Mocking these static methods allows for:
oh, this should also contain like 2-3 tests for the admin controllers.