Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ezETH/WETH Market Deployment #109

Merged
merged 5 commits into from
Jul 1, 2024
Merged

ezETH/WETH Market Deployment #109

merged 5 commits into from
Jul 1, 2024

Conversation

junkim012
Copy link
Collaborator

@junkim012 junkim012 commented Jul 1, 2024

  • ezETH/WETH Market contracts including SpotOracle, ReserveOracle, and ezETHHandler.

Copy link

ezETH/WETH Market Deployment

Generated at commit: 40edcbe7a1acd644203ba1d484b718b3940e47c5

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
12
40
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

@jpick713 jpick713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/Constants.sol Show resolved Hide resolved
Copy link

@CarsonCase CarsonCase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per TG : "Looks pretty good to me, config addresses are correct and the rounding in the oracle goes reserve down, spot up.

I have a few questions just about how deployments are done in general. If we're doing those Base deployments or something soon I'd love to tag along again"

@junkim012 junkim012 merged commit 3da1aad into master Jul 1, 2024
5 of 6 checks passed
@junkim012 junkim012 deleted the jun/ezETH-WETH-deployment branch July 1, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants