Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OZ] H-02 #111

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[OZ] H-02 #111

merged 1 commit into from
Jul 29, 2024

Conversation

junkim012
Copy link
Collaborator

@junkim012 junkim012 commented Jul 6, 2024

H-02

  • Adds the hard-coded 4 extra precision through DECIMALS_OFFSET
  • Removes the burning of 1e3 initial shares from the VaultFactory. The factory now only deploys the bytecode with a salt and does nothing else.
  • Tests were modified to account for the fact that shares now have 22 decimals (18 decimals for ETH-correlated underlying assets and 4 extra).

@junkim012 junkim012 changed the base branch from master to jun/oz-vault-upgrade-audit-merge July 6, 2024 01:30
Copy link

[OZ] H-02

Generated at commit: a6130ea230ea64e5affee63808594c44aab85d14

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
12
39
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

CarsonCase

This comment was marked as duplicate.

@junkim012 junkim012 merged commit eb01b48 into jun/oz-vault-upgrade-audit-merge Jul 29, 2024
4 of 6 checks passed
@junkim012 junkim012 deleted the jun/OZ-H-02 branch July 29, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants