Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI checks #50

Merged
merged 12 commits into from
Feb 18, 2024
Merged

CI checks #50

merged 12 commits into from
Feb 18, 2024

Conversation

HrikB
Copy link
Contributor

@HrikB HrikB commented Feb 5, 2024

Adding checks in the CI to be run before PR merges.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Feb 5, 2024 •
edited
Loading

CI checks

Generated at commit: cc0083b8066388c94d252d0c095d26974a6b8785

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
0
0
5
7
12
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@HrikB HrikB force-pushed the hrikb/ci branch 14 times, most recently from 18dcb46 to 306ca5c Compare February 7, 2024 03:34
@junkim012 junkim012 force-pushed the hrikb/ci branch 2 times, most recently from 7432490 to 9349a6d Compare February 7, 2024 08:29
@HrikB HrikB force-pushed the hrikb/ci branch 2 times, most recently from 9349a6d to 306ca5c Compare February 7, 2024 15:49
@HrikB HrikB requested a review from junkim012 February 18, 2024 19:56
@HrikB HrikB marked this pull request as ready for review February 18, 2024 19:56
@HrikB HrikB merged commit 321910f into master Feb 18, 2024
5 of 6 checks passed
@HrikB HrikB deleted the hrikb/ci branch February 18, 2024 22:27
HrikB added a commit that referenced this pull request Feb 19, 2024
@HrikB @anduckworth
CI checks (#50)
a4338e6 
* chore: ci

* fmt: run forge fmt

* chore: link validation in ci

* chore: spell check

* chore: ci for tests and solhint

* fix: solhint ci

* fix: forge test ci

* chore: slither ci and triage

* feat: foundry-storage-check

* fix: remove tests from ci

* chore: add husky hooks

* Update README.md

---------

Co-authored-by: Alex Narvaez-Duckworth <[email protected]>
HrikB added a commit that referenced this pull request Feb 23, 2024
@HrikB @junkim012 @anduckworth
WeEth Integration Audit Changes Merged (#59)
2c0d7eb 
* feat: weETH reserve oracle and fork tests

* feat: wstETH per weETH spot oracle and tests

* feat: WeEthHandler

* fix: weETH wstETH spot oracle now uses market price instead of exchange rate for valuing stETH against ETH

* chore: global imports and removed blockNumber setter

* test: test the WeEthHandler

* refactor: generalize UniswapFlashswapDirectMint for any market instance

* docs: document the

* style: rename amountLrt to amountOut

* docs: EtherFi library natspec

* refactor: move REDSTONE_DECIMALS to Constants.sol and make last update time in spot oracle immutable

* fix: replace wstETH with weETH

* fix: UniswapFlashswapDirectMint should compare maxResultingDebt against input wstEth amount from swap

* chore: reduce reserve oracle cooldown to 58 min

* test: fuzz the WeEthHandler

* fix: handle rounding error on EtherFiLibrary

* chore: docs and cleanup

* refactor: make Liquidation contract support IonPool when ilkCount != 3

* feat: add new Pause role for the pause() function and add pausability for the mintAndBurnGem() function

* fix: reserve factor input validation

* fix: merge conflict

* Update README.md

* CI checks (#50)

* chore: ci

* fmt: run forge fmt

* chore: link validation in ci

* chore: spell check

* chore: ci for tests and solhint

* fix: solhint ci

* fix: forge test ci

* chore: slither ci and triage

* feat: foundry-storage-check

* fix: remove tests from ci

* chore: add husky hooks

* Update README.md

---------

Co-authored-by: Alex Narvaez-Duckworth <[email protected]>

* fix: solhint and slither

* slither

* fix: remove arrays from Liquidation constructor args

* fix: slither

---------

Co-authored-by: Jun Kim <[email protected]>
Co-authored-by: Alex Narvaez-Duckworth <[email protected]>
HrikB added a commit that referenced this pull request Feb 23, 2024
@HrikB @junkim012
@teryanarmen @anduckworth
WeEth Market Deployment (#49)
701925d 
* feat: weETH reserve oracle and fork tests

* feat: wstETH per weETH spot oracle and tests

* feat: WeEthHandler

* clean 2

* chore: forge fmt

* Create LICENSE

BUSL License

* update LICENSE

* chore: SPDX-License-Identifiers

* chore: casing

* feat: weETH reserve oracle and fork tests

* feat: wstETH per weETH spot oracle and tests

* forge install: forge-safe

* feat: cli tool to target script and contracts to run

* fix: weETH deployment for YieldOracle
feat: deployment script fork tests

* fix: weETH wstETH spot oracle now uses market price instead of exchange rate for valuing stETH against ETH

* chore: global imports and removed blockNumber setter

* test: test the WeEthHandler

* refactor: generalize UniswapFlashswapDirectMint for any market instance

* docs: document the

* style: rename amountLrt to amountOut

* docs: EtherFi library natspec

* refactor: move REDSTONE_DECIMALS to Constants.sol and make last update time in spot oracle immutable

* fix: replace wstETH with weETH

* feat: deployment script tests

* wip: bash deploy

* feat: single asset deployment tests and ionPool createX deployment

* chore: deployment cleanup and input validation

* feat: multisig action scripts

* feat: refactor deployment scripts with input validation

* feat: multisig action scripts

* fmt: format

* fix: local node deployments scripts

* fix: revert Liquidation changes

* fix: deployment scripts with create3 addresses

* chore: update env.example

* fix: make WeEthIonPoolSharedSetup setUp() virtual

* refactor: rename Liqudation variables

* refactor: __TestFlashswapLeverage script for WeEth market and add gemJoin to output from deploy-sim.sh

* fix: UniswapFlashswapDirectMint should compare maxResultingDebt against input wstEth amount from swap

* fix: UniswapFlashswapDirectMint should compare maxResultingDebt against input wstEth amount from swap

* chore: reduce reserve oracle cooldown to 58 min

* test: fuzz the WeEthHandler

* fix: handle rounding error on EtherFiLibrary

* chore: docs and cleanup

* refactor: make Liquidation contract support IonPool when ilkCount != 3

* feat: add new Pause role for the pause() function and add pausability for the mintAndBurnGem() function

* feat: multisig deployment

* fix: reserve factor input validation

* fix: merge conflict

* Update README.md

* CI checks (#50)

* chore: ci

* fmt: run forge fmt

* chore: link validation in ci

* chore: spell check

* chore: ci for tests and solhint

* fix: solhint ci

* fix: forge test ci

* chore: slither ci and triage

* feat: foundry-storage-check

* fix: remove tests from ci

* chore: add husky hooks

* Update README.md

---------

Co-authored-by: Alex Narvaez-Duckworth <[email protected]>

* fix: solhint and slither

* slither

* fix: spell check

* feat: AdminTransfer script

* feat: deployment script for ion pool implementation

* chore: dry run

* fix: remove arrays from Liquidation constructor args

* fix: slither

* fix: slither

* test: integration tests (#60)

* feat: YieldOracleNull

* feat: YieldOracleNull deployment script

---------

Co-authored-by: Jun Kim <[email protected]>
Co-authored-by: teryanarmen <[email protected]>
Co-authored-by: Alex Narvaez-Duckworth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkim012 junkim012 junkim012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HrikB @junkim012 @anduckworth