Added Ore Siphon #34
Open
Added Ore Siphon #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly build script changes - updated IridiumCore to 1.8.9 - updated IridiumSkyblockAPI to 4.0.8 - updated SuperiorSkyblockAPI to use new repo - updated script to include LandsAPI because this wasn't here for some reason - removed MassiveCore and MassiveCore Factions because this is no longer available to compile with [see their github profile](https://github.com/MassiveCraft)
- updated WordUtils and NotImplementedException from core - fixed the name and display name for enchantments being swapped in the GUI - Added the VeinMine effect, with config options to determine what blocks you can mine with it, whether the enchantment can break tools, whether to allow the wrong tool to mine it, and what the cap on processed blocks is. The effect can be configured to have a chance not to damage the tool being used. - ill be real i have no idea what happened in the DropHead class
GNUGradyn
reviewed
May 8, 2024
| || itemStack.getType().name().toUpperCase().contains("HOE"); | ||
| } | ||
|
|
||
| private int damageTool(int blockCount, ItemStack itemStack, int chance) { |
There was a problem hiding this comment.
maybe rename this to something like getToolDamage? damageTool sounds like it applys the damage to the tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is this in master??? dude idk