Fix inaccurate block stacks #879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a lot of changes with how the code looks; I can change it back to how it looked before for consistency idk |
PeachesMLG
requested changes
Jul 21, 2024
| } | ||
|
|
||
| private void processBlock(int x, int y, int z, @NotNull Chunk chunk, @NotNull ChunkSnapshot chunkSnapshot, @NotNull Map<XMaterial, Integer> teamBlocks) { | ||
| Block block = chunk.getBlock(x, y, z); |
There was a problem hiding this comment.
Is this thread safe? Remember this is running async
| teamBlocks.merge(material, amount, Integer::sum); | ||
| } | ||
|
|
||
| public boolean isBlockStacked(Block block) { |
There was a problem hiding this comment.
Is this needed? getStackAmount defaults to 1 if its not present anyway?
Stacked Blocks always have one more than the actual amount, since we count the placed block as well as the amount of blocks inside the "stack"
dlsf
force-pushed
the
fix-inaccurate-block-stacks
branch
from
5d8f694
to
ce50469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked Blocks always have one more than the actual amount, since we count the placed block as well as the amount of blocks inside the "stack"