Display array base when nonzero #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several changes I have stashed since several years ago that never got to the top of the priority list because the functionality looked so fringe or insignificant. I am submitting them now, before the code restructuring tsunami hits.
One of the oddities of .NET is support of arbitrary-based arrays. They are clumsy to create and use, esp. in strongly typed languages, but there they are. Support of them in IronPython is somewhat unfinished, probably for good reason, since it is such a fringe concept, and perhaps never used in anything serious.
Since two arrays with identical content but different bases (lower bounds) are not the same, their
reprstring should be different. This PR adds the display of the base in case it is non-zero.