Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give more time in test__socket for server to start up #1836

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Give more time in test__socket for server to start up #1836

merged 2 commits into from
Dec 10, 2024

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Dec 10, 2024

No description provided.

slozier
slozier approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an ugly test... Fine by me. 😊

@slozier
Copy link
Contributor

slozier commented Dec 10, 2024

@BCSharp Sorry, I hijacked your PR. Hopefully I didn't break things.

@BCSharp
Copy link
Member Author

BCSharp commented Dec 10, 2024

OMG, I coudn't stop laughing... It is an ugly test indeed. For me, every time I saw test__socket failing again, I was ready to shoot myself. This was not something I wanted to put my attention to. Thanks for any improvements and fixes.

On another note, I see that the GitHub macOS CI is failing because of lack of funds? It there a monthly limit of sorts? If so, when does it reset? How did it get chewed up? Did the hundreds of restructure commits pushed to GitHub one by one eat up all the budget?

@BCSharp BCSharp merged commit bde56ce into IronLanguages:main Dec 10, 2024
7 of 8 checks passed
@BCSharp BCSharp deleted the test__socket_grace branch December 10, 2024 04:14
@slozier
Copy link
Contributor

slozier commented Dec 10, 2024

On another note, I see that the GitHub macOS CI is failing because of lack of funds? It there a monthly limit of sorts? If so, when does it reset? How did it get chewed up? Did the hundreds of restructure commits pushed to GitHub one by one eat up all the budget?

No idea about the funds thing, as far as I can tell it's going through the .NET Foundation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCSharp @slozier