-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodetect processor architecture used for tests #1837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProcessArchitecture
doesn't look like an exact mapping for TargetPlatform
, but I guess it sort of works.
Based on docs, if we omit the TargetPlatform
tag it'll auto-detect. So might be slightly cleaner to not default platform to anything and omit RunConfiguration
if unset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hmm, it seems not to work for UPDATE: I see that |
I'm fine with ditching |
If you are planning to do a release soon, maybe it's worth waiting with the removal till right after the release. |
Yes, I do want to release soon. .NET 9 issue has come up a number of times. Anyway, I just need to figure out the .NET tool issue and I can start testing the packages. |
Will you have to prepare a release of the DLR too? |
Yes, I believe you added some new API surface that we're using since the last release. Did you have additional changes you needed to squeeze in? |
Yes, I have some changes to the DLR in the pipeline; none of which need to be squeezed in before the release. However if you didn't have to do a DLR release I would hold off on those changes not to force an additional release. Since the release is happening anyway, I'll just let them run their course and submit them as they become ready. |
Useful on macOS.