Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Receives Cashout" parsing to GGPoker parser. #89

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

RuijieZ
Copy link

@RuijieZ RuijieZ commented Nov 30, 2023

  • Add a new winning type "CASHOUT"
  • Add parsing to string "xyz: Receives Cashout ($9.8)" in GGPoker parser. This is when the player lost the hand but get paid due to they choose to cashout.
  • Add unit tests.

@ItalyToast
Copy link
Owner

Cashout, Is that from some kind of insurance? if so maybe we can call it INSURANCE_CASHOUT?

A short description on the enum may be appropiate since CASHOUT is not common on other sites.

@RuijieZ
Copy link
Author

RuijieZ commented Nov 30, 2023

Yes, it is one form of an insurance: https://www.ggpoker.com/poker-games/ev-cashout/

It is also present in pokerstars as well: https://www.pokerstars.com/poker/all-in-cash-out/, not sure about other sites.

I will update the pr soon. And will looking into how to support that for Pokerstars parser in a different pr.

@ItalyToast
Copy link
Owner

ItalyToast commented Nov 30, 2023

Thank you for the link.

And will looking into how to support that for Pokerstars parser in a different pr.

sounds good

if so maybe we can call it INSURANCE_CASHOUT?

Thinking we call it just INSURANCE since we most likely dont care what kind of insurance the player used.

@RuijieZ
Copy link
Author

RuijieZ commented Nov 30, 2023

Changed the name from Cashout to Insurance. Please take a look.

@ItalyToast ItalyToast merged commit f903790 into ItalyToast:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants