Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond integration tests & migration #79

Merged
merged 18 commits into from
Mar 12, 2024
Merged

Bond integration tests & migration #79

merged 18 commits into from
Mar 12, 2024

Conversation

bucurdavid
Copy link
Member

No description provided.

bucurdavid added 14 commits March 6, 2024 17:32
@Itheum Itheum deleted a comment from github-actions bot Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Coverage after merging d-david into develop

76.54%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bonding_proxy.rs100%100%100%25
   collection_management.rs100%0%0%..., 96, 97, 98, 99
   lib.rs100%100%99.20%307, 322
   nft_mint_utils.rs100%100%100%
   requirements.rs100%100%100%

@newbreedofgeek
Copy link
Member

tnx @bucurdavid

I can see that we are now using the proxy implementation.

@damienen can you code review pls.

After which i'll upgrade the devnet minter so we can test the new proxy work.

damienen
damienen suggested changes Mar 8, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/endpoints/collection_management.rs Show resolved Hide resolved
tests/endpoints/mint.rs Show resolved Hide resolved
@bucurdavid bucurdavid requested a review from damienen March 8, 2024 06:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Coverage after merging d-david into develop

76.49%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bonding_proxy.rs100%100%100%25
   collection_management.rs100%0%0%..., 96, 97, 98, 99
   lib.rs100%100%99.20%303, 318
   nft_mint_utils.rs100%100%100%
   requirements.rs100%100%100%

@bucurdavid bucurdavid requested a review from damienen March 11, 2024 08:31
@github-actions GitHub Actions
Copy link

Coverage after merging d-david into develop

76.54%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bonding_proxy.rs100%100%100%25
   collection_management.rs100%0%0%..., 96, 97, 98, 99
   lib.rs100%100%99.20%306, 321
   nft_mint_utils.rs100%100%100%
   requirements.rs100%100%100%

@github-actions GitHub Actions
Copy link

Coverage after merging d-david into develop

76.54%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   bonding_proxy.rs100%100%100%25
   collection_management.rs100%0%0%..., 96, 97, 98, 99
   lib.rs100%100%99.20%306, 321
   nft_mint_utils.rs100%100%100%
   requirements.rs100%100%100%

@newbreedofgeek newbreedofgeek merged commit 95778f1 into develop Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienen damienen damienen approved these changes

@newbreedofgeek newbreedofgeek newbreedofgeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bucurdavid @newbreedofgeek @damienen