Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Improve tvdb more #40

Merged
merged 9 commits into from
Jul 21, 2024
Merged

Improve tvdb more #40

merged 9 commits into from
Jul 21, 2024

Conversation

Paillat-dev
Copy link
Collaborator

@Paillat-dev Paillat-dev commented Jul 21, 2024

lol

Closes: #37

@Paillat-dev Paillat-dev requested a review from ItsDrike July 21, 2024 21:30
src/exts/tvdb_info/main.py Outdated Show resolved Hide resolved
src/exts/tvdb_info/main.py Outdated Show resolved Hide resolved
src/tvdb/client.py Outdated Show resolved Hide resolved
src/tvdb/client.py Outdated Show resolved Hide resolved
src/tvdb/client.py Outdated Show resolved Hide resolved
src/tvdb/client.py Outdated Show resolved Hide resolved
src/exts/tvdb_info/main.py Outdated Show resolved Hide resolved
Paillat-dev and others added 2 commits July 22, 2024 00:10
@Paillat-dev
Copy link
Collaborator Author

Paillat-dev commented Jul 21, 2024

You can avoid them by turning by_id into a keyword-only argument

But that's a discord command. Like I know that, just wasn't sure if it was good to put *, there-

@ItsDrike
Copy link
Owner

But that's a discord command.

Ohh right, somehow I didn't connect that together, lol.

Like I know that, just wasn't sure if it was good to put *, there-

Hmm, try it I guess, see if it works

@Paillat-dev Paillat-dev requested a review from ItsDrike July 21, 2024 22:36
@Paillat-dev Paillat-dev merged commit a6ab0ef into main Jul 21, 2024
7 checks passed
@ItsDrike ItsDrike deleted the tvdb-fixes branch July 21, 2024 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception
2 participants