Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Commit

Permalink
Fixes and misc (#2875)
Browse files Browse the repository at this point in the history
* Make the "Demo" telegram build faster

* Improve the uploaded Code Coverage report

* Add more tests
ILIYANGERMANOV authored Jan 15, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 1c10d23 commit 4e24d70
Showing 4 changed files with 25 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -54,11 +54,12 @@ jobs:
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-
- name: Code Coverage
run: ./gradlew koverHtmlReport

- name: Upload Code Coverage Report
- name: Upload Code Coverage report
uses: actions/upload-artifact@v4
with:
name: code-coverage-report
path: app/build/artifacts/reports/kover/coverageResults/index.html
path: app/build/artifacts/reports/kover/coverageResults/*
1 change: 0 additions & 1 deletion app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -81,7 +81,6 @@ android {
)

matchingFallbacks.add("release")
matchingFallbacks.add("debug")

isDebuggable = true
isDefault = false
Original file line number Diff line number Diff line change
@@ -112,5 +112,16 @@ class AccountMapperTest : FreeSpec({
// then
result.shouldBeRight()
}

"invalid icon is okay" {
// given
val invalidIconEntity = entity.copy(icon = "invalid icon")

// when
val result = with(mapper) { invalidIconEntity.toDomain() }

// then
result.shouldBeRight()
}
}
})
Original file line number Diff line number Diff line change
@@ -94,5 +94,16 @@ class CategoryMapperTest : FreeSpec({
// then
res.shouldBeRight()
}

"invalid icon is okay" {
// given
val invalidIconEntity = categoryEntity.copy(icon = "invalid icon")

// when
val result = with(mapper) { invalidIconEntity.toDomain() }

// then
result.shouldBeRight()
}
}
})

0 comments on commit 4e24d70

Please sign in to comment.