-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMC general output processing for simple tokamak model #333
Conversation
Codecov ReportAttention: Patch coverage is
|
…to omc-tokamak-out
before considering approving we need to go through the type hint and docstring of |
…to omc-tokamak-out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to increase level of abstraction and first implementation for capability to process OpenMC outputs using the API. Very nice additions plus substantial improvement to docstrings across codebase.
Description
This is a first pass at implementing output data processing for a general computational benchmark in OpenMC. The approach uses the OpenMC. API to generate a native pandas dataframe for each tally, with subsequent post-processing conducted to formulate consistently with other simulation outputs. Further work is required to correctly normalize OpenMC. tally outputs, for example, applying volume corrections, and combining photon, positron and electron contributions for photon heating tallies. So far, this has been demonstrated for the new Simple Tokamak benchmark.
Type of change
Please select what type of change this is.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: