Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Alex benchmarks (Issue #229) #344

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Conversation

AlbertoBittes
Copy link
Collaborator

Description

Inclusion of UKAEA benchmarks as per Issue #229. Code has been modified and tests updated. MCNP inputs/WWs and Experimental data will be managed separately.

Fixes #229

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Other changes

  • This change requires a documentation update
  • (If Benchmark) This requires additional data that can be obtained from:
    • Benchmark data 1
    • Benchamrk data 2

Testing

test_fnghcpboutput() was added to expoutput.py test file.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 93.62745% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
jade/expoutput.py 95.89% 8 Missing ⚠️
jade/postprocess.py 37.50% 5 Missing ⚠️
Files with missing lines Coverage Δ
jade/computational.py 71.23% <ø> (ø)
jade/plotter.py 96.05% <100.00%> (ø)
jade/status.py 87.82% <ø> (ø)
jade/postprocess.py 36.47% <37.50%> (-1.51%) ⬇️
jade/expoutput.py 93.48% <95.89%> (+1.33%) ⬆️

@alexvalentine94
Copy link
Collaborator

NOTE. bmark_addtion_1 can be removed following merge.

@alexvalentine94 alexvalentine94 marked this pull request as ready for review November 6, 2024 08:32
Copy link
Collaborator

@alexvalentine94 alexvalentine94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up @AlbertoBittes !

@alexvalentine94 alexvalentine94 merged commit d6fcd2c into developing Nov 6, 2024
9 checks passed
@alexvalentine94 alexvalentine94 deleted the alex-benchmarks branch November 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants