Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL implementation for aircraft/user-defined level upward/downward #189

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

chengdang
Copy link
Contributor

@chengdang chengdang commented Nov 25, 2024

Description

This PR contains:

  • TL implementation for aircraft/user-defined level upward/downward radiance calculation, see module CRTM_ADA_TL
  • Updates to code format for module CRTM_ADA
  • New notes and comments in ADA_Module.f90
  • New ctests for aircraft/downward modules

Issue(s) addressed

#182

Dependencies

None

Impact

TL results of aircraft level calculation are updated.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@chengdang
Copy link
Contributor Author

@quanhualiu, hello Mark, as we discussed, this is the TL implementation for the updated aircraft level calculation.
Could you please review the implementation, especially the new equations in module CRTM_ADA_TL. Thank you!

Copy link
Contributor

@StegmannJCSDA StegmannJCSDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengdang Thank you for including me in the review. I just have a few comments so far:

  • Are there any test results that highlight the impact of the changes in the Forward module?
  • Do the changes for the aircraft mode debugging and the downwelling radiance overlap, or could they have been split up in two PRs?
  • Did you use TAPENADE to derive the TL code, or by hand?
  • For the regression tests, the Load_Atm_Data.inc file etc. is repeated in a lot of folders now. Would it make sense to move it down at this point, e.g. to mains/regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants