Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsi validation netcdf #207

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ADCollard
Copy link

Description

Changes required to use netCDF files by default. Added missing routines for antenna correction coefficients.

Issue(s) addressed

Partially Resolves #192

Dependencies

None

Impact

Expected impact on downstream repositories: None

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ADCollard
Copy link
Author

Putting this Draft PR in for initial review. It is still a draft PR as:

  1. I am still getting seg faults when running the code from the GSI
  2. The changes to src/Coefficients/FitCoeff/FitCoeff_Define.f90 that were reversed are still in this version as we still need to address this.

Right now inclusion of CRTMv3 with GFSv17 is unlikely given the issues with seg faults.

@BenjaminTJohnson
Copy link
Contributor

@ADCollard I was in Italy last week, so just now getting back to this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some bug fixes to ensure CRTMv3 can run with netCDF files
2 participants