Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pst mwsurfem #208

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

StegmannJCSDA
Copy link
Contributor

Description

This PR adds a new unit test test_MWSurfEM that tests the CRTM_SfcOptics, ONLY: CRTM_Compute_SfcOptics function for all 22 channels of atms_npp.
The test is a preliminary for future MW surface emissivity code changes.

Output:

  • The unit test is successful if Error_Status==SUCCESS is asserted for all included function calls, most importantly for CRTM_Compute_SfcOptics.
  • The test prints one SfcOptics%Emissivity for each ChannelIndex.

Issue(s) addressed

Resolves StegmannJCSDA#1.

Dependencies

  • Requires atms_npp SpcCoeff coefficients in test data.

Impact

Expected impact on downstream repositories:

  • One additional unit test for all repositories that call CRTMv3 unit tests during their build process.
  • Increased test time: ca. +0.3 sec.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Copy link
Contributor

@chengdang chengdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looking great. All unit tests passed with gfortran.

@@ -106,7 +106,7 @@ PROGRAM test_TL
! -----------------------
!WRITE( *,'(/5x,"Enter sensor id [hirs4_n18, amsua_metop-a, or mhs_n18]: ")',ADVANCE='NO' )
!READ( *,'(a)' ) Sensor_Id
Sensor_Id = 'amsua_metop-a'
Sensor_Id = 'atms_n21'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: any particular reason to replace this with atms_n21?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unit Tests for MW Surface Emissivity Procedures
2 participants