Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WGRIB variable to grib-util module #1101

Merged
merged 5 commits into from
May 21, 2024

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented May 3, 2024

Summary

This PR adds a variable WGRIB for the wgrib executable in the grib-util module.

Testing

Tested on personal machine

Applications affected

UPP, Global Workflow, EMC verif

Systems affected

all

Dependencies

none

Issue(s) addressed

#1097

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA Ready for review?

@climbfuji
Copy link
Collaborator

This needs to be back-ported to 1.5.1 and 1.6.0 on all systems (module generation only)

@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA This PR still says "testing in progress" - has this been done? @DavidHuber-NOAA mentioned in the last meeting that this needs to be rolled into 1.5.1 and 1.6.0. Thanks!

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Yes this is good to go, let me know if you want me to do some of the backporting.

@climbfuji
Copy link
Collaborator

I think we need the usual list of platforms and then work with @RatkoVasic-NOAA and @srherbener to make the one-line change (manually I suggest) in the env common config for 1.5.1 and 1.6.0?

@climbfuji climbfuji enabled auto-merge May 21, 2024 03:24
@climbfuji climbfuji merged commit 084db01 into JCSDA:develop May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants