Remove LaTeX documentation from readthedocs #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/NewSiteConfigs.rst
climbfuji
requested review from
srherbener,
RatkoVasic-NOAA and
AlexanderRichert-NOAA
| @@ -1,15 +1,9 @@ | |||
| cmake_minimum_required(VERSION 3.18 FATAL_ERROR) | |||
|
|
|||
| project(spack-stack VERSION 1.3.1) | |||
There was a problem hiding this comment.
Is there a way to get the version automatically? If we don't set the next version anywhere else then nevermind.
There was a problem hiding this comment.
We do, in doc/src/conf.py we can use dev and develop for the short and long version in between releases, and then I set them on the release branch. CMakeLists.txt unfortunately doesn't allow that, only real versions.
Would be nice if we could set the version in one place and then inherit it from there. But probably a heavy lift, given that it's only three places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove LaTeX documentation from the readthedocs configuration and fix two formatting errors in
doc/source/NewSiteConfigs.rst. There are four warnings when I build the documentation manually, but no errors anymore. I checked the rendered HTML documentation, and the output looks ok (not sure what the warnings are about).Testing
See readthedocs build below (https://spack-stack--1346.org.readthedocs.build/en/1346/NewSiteConfigs.html)
Applications affected
none
Systems affected
none
Dependencies
none
Issue(s) addressed
Resolves #1069
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.